[Webkit-unassigned] [Bug 33336] webkit-patch rollout should be able to do multi-revision rollouts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33336





--- Comment #8 from Eric Seidel <eric at webkit.org>  2010-12-09 11:01:21 PST ---
(From update of attachment 76028)
View in context: https://bugs.webkit.org/attachment.cgi?id=76028&action=review

Have you run test-webkitpy?  Have you don a real rollout with this yet? (You can do that by having your changes in one webkit checkout and operating on a differnet one.  webkit-patch is smart enough to operate on the cwd while pulling its .py files from paths relative to it's __file__ location.

> WebKitTools/Scripts/webkitpy/common/checkout/changelog.py:157
> +        for revision in revision_list:

We have to be careful when passing lists as strings count as lists.  If there is any chance someone might pass a string for the revision_list it will do strange things.

> WebKitTools/Scripts/webkitpy/tool/commands/download_unittest.py:65
> +        state = command._prepare_state(None, ["rev r122  125  123", "Reason"], None)

What's the 'rev' here?

> WebKitTools/Scripts/webkitpy/tool/commands/download.py:309
> +        # We use the earliest revision for the bug info
> +        earliest_revision = revision_list[0]
> +        commit_info = self._commit_info(earliest_revision)

I'm not sure we don't want to process each bug individually, but this might be ok for now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.