[Webkit-unassigned] [Bug 48926] Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48926


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75967|review?                     |review+
               Flag|                            |




--- Comment #8 from Ojan Vafai <ojan at chromium.org>  2010-12-09 09:48:35 PST ---
(From update of attachment 75967)
View in context: https://bugs.webkit.org/attachment.cgi?id=75967&action=review

This looks great!

> LayoutTests/ChangeLog:9
> +	For all test_expectations.txt files, change all occurrences of BUG to
> +	either BUGCR or BUGWK.

Indentation is off here. Use spaces, not tabs.

> WebKitTools/ChangeLog:9
> +	Add presubmit check that BUG isn't used, either BUGCR or BUGWK.

ditto re: spaces

> WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:600
> +                self._add_error(lineno, 'Bug must be either BUGCR or BUGWK for test: %s' %

Nit: now there is also BUGV8_XXX

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.