[Webkit-unassigned] [Bug 50714] [Skia] Improve PNG compression by stripping the alpha channel when it's fully opaque

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50714





--- Comment #3 from Adam Barth <abarth at webkit.org>  2010-12-09 09:07:07 PST ---
(From update of attachment 75963)
View in context: https://bugs.webkit.org/attachment.cgi?id=75963&action=review

> WebCore/ChangeLog:16
> +        No new tests.

We should figure out a way to test this change.

> WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp:48
> +static bool degenerateAlphaInARGB(const unsigned char* input,
> +                                  const IntSize& size,
> +                                  int bytesPerRow)

This should be on one line.

> WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp:71
> +static void preMultipliedBGRAtoRGB(const unsigned char* input,
> +                                   int numberOfPixels,
> +                                   unsigned char* output)

As should this.

> WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp:90
> -static void preMultipliedBGRAtoRGBA(const unsigned char* input, int numberOfPixels,
> +static void preMultipliedBGRAtoRGBA(const unsigned char* input,
> +                                    int numberOfPixels,

This should stay on one line.  WebKit doesn't have an 80 col limit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.