[Webkit-unassigned] [Bug 50738] [GTK] Choose a dictionary in case there is no one defined or the env LANG does not propose one

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 9 04:33:31 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=50738


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76043|review?                     |review+
               Flag|                            |




--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2010-12-09 04:33:31 PST ---
(From update of attachment 76043)
View in context: https://bugs.webkit.org/attachment.cgi?id=76043&action=review

Thank you! Please fix the remaining minor issues before landing.

> WebKit/gtk/webkit/webkitwebsettings.cpp:953
> +static void getAvilableDictionariesCallback(const char* const lang_tag, const char* const provider_name, const char* const provider_desc, const char* const provider_file, void* data)

Please change lang_tag to languageTag before landing. You should actually omit provider_name, provider_desc, and provider_file to avoid a warning here too.

> WebKit/gtk/webkit/webkitwebsettings.cpp:955
> +    Vector<CString>* dicts = static_cast< Vector<CString>* >(data);

Please remove the extra space after the static_cast< before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list