[Webkit-unassigned] [Bug 25533] [GTK] Elements on the same line should be treated as such by caret navigation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 9 04:18:01 PST 2010


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
  Attachment #76044|                            |review?
               Flag|                            |

--- Comment #4 from Mario Sanchez Prada <msanchez at igalia.com>  2010-12-09 04:18:00 PST ---
Created an attachment (id=76044)
 --> (https://bugs.webkit.org/attachment.cgi?id=76044&action=review)
Patch proposal + New layout test

I'm attaching a patch to fix this bug (along with a new layout test) I've written this week during the WebKitGTK hackfest, making the following assumptions:

  - It will affect the GTK port only. Other ports will keep working as they used to do and the new functionality introduced is just irrelevant for them.
  - Following Martin Robinson's suggestion to avoid introducing and JS API breakage with the "MoveDown" and "MoveUp" editing commands, I've created new commands for moving up and down (with or without extending a selection) *specifically designed to be used when in caret browsing mode only* which, so far should only affect the GTK port, as the rest of the ports would keep using the "MoveDown"/"MoveUp" commands.
  - In the layout test I'm not only checking the behaviour of this patch when in caret browsing mode but also that the "MoveDown" and "MoveUp" commands (in GTK used only when NOT in caret mode) keep being the same ones than they used to be, to confirm no JS API breakage happened here.

I understand this could be not an easy patch to get accepted, as it introduced four new editing commands that are only needed by the GTK port, but after thinking for a long time and getting a lot of support from Martin, we thought that perhaps this could be the best option to avoid risking the JS API, whenever the patch also provided a good enough layout test for it.

Eager to get some feedback. Thanks!

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list