[Webkit-unassigned] [Bug 50739] [GTK] Add hasSpellingMarker support to the DRT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 9 03:07:06 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=50739


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76031|review?                     |review+
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2010-12-09 03:07:06 PST ---
(From update of attachment 76031)
View in context: https://bugs.webkit.org/attachment.cgi?id=76031&action=review

> WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:418
> +    return coreFrame->editor()->selectionStartHasSpellingMarkerFor(from, length);

Maybe just core(frame)->... here before landing.

> WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:74
> +    static bool webkitWebFrameSelectionHasSpellingMarker(WebKitWebFrame *frame, gint from, gint length);

Please remove the variable name before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list