[Webkit-unassigned] [Bug 50738] [GTK] Choose a dictionary in case there is no one defined or the env LANG does not propose one

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50738


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76025|review?                     |review-
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2010-12-09 02:14:53 PST ---
(From update of attachment 76025)
View in context: https://bugs.webkit.org/attachment.cgi?id=76025&action=review

Yay! Thanks for fixing this.

> WebKit/gtk/webkit/webkitwebsettings.cpp:953
> +static void get_avail_dicts_cb(const char * const lang_tag, const char * const provider_name, const char * const provider_desc, const char * const provider_file, void * data)

Should be in WebKit style (camelCase), asterisks with the typenames and use full words instead of abbreviations. :)

> WebKit/gtk/webkit/webkitwebsettings.cpp:1079
> +                // No dictionaries selected, we get one from the list
> +                enchant_broker_list_dicts(broker, get_avail_dicts_cb, &dicts);
> +                if (dicts) {
> +                    GSList* tmp;

Instead of passing a GSList* it might simplify things to pass a point to a Vector<CString> like:

Vector<CString> allDictionaries;
enchant_broker_list_dicts(broker, getAvilableDictionariesCallback, &allDictionaries);
if (!allDictionaries.empty()) {
      ...

}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.