[Webkit-unassigned] [Bug 50365] Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Linux and Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50365


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76016|review?                     |review-
               Flag|                            |




--- Comment #11 from Kent Tamura <tkent at chromium.org>  2010-12-08 22:51:42 PST ---
(From update of attachment 76016)
View in context: https://bugs.webkit.org/attachment.cgi?id=76016&action=review

style comments.

> WebCore/platform/graphics/chromium/FontPlatformDataLinux.cpp:83
> +#if 0

Unused code should be removed.

> WebCore/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:65
> +        if (!error) 

Should add { } because the block has two physical lines.

> WebCore/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:70
> +    } else
> +        // if there is no GSUB table, treat it as not covered
> +        error = 0Xffff;

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.