[Webkit-unassigned] [Bug 45870] [reviewtool] should always show overall comments text box

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45870





--- Comment #5 from Adam Barth <abarth at webkit.org>  2010-12-08 19:10:06 PST ---
(From update of attachment 75945)
View in context: https://bugs.webkit.org/attachment.cgi?id=75945&action=review

> BugsSite/ChangeLog:11
> +        (.):
> +        ():

I usually remove these lines from the ChangeLog because they're kine of meaningless.

> BugsSite/PrettyPatch/PrettyPatch.rb:210
> +  display: -webkit-box;
> +  display: -moz-box;

Woah, you're blowing my mind.

> BugsSite/code-review.js:250
> -      $('#toolbar .actions').append($('<iframe class="statusBubble" src="https://webkit-commit-queue.appspot.com/status-bubble/' + attachment_id + '" scrolling="no"></iframe>'));
> +      $('#toolbar .actions').append($('<br><iframe class="statusBubble" src="https://webkit-commit-queue.appspot.com/status-bubble/' + attachment_id + '" scrolling="no"></iframe>'));

So, actually, I would put the bubbles above the preview / publish buttons.  That's because I expect people to look at the bubbles before clicking the buttons, so they should be visually linear instead of requiring the user's eyes to move down and then up again.

> BugsSite/code-review.js:275
> +        '<div class="links"><span class="bugLink"></span></div>' +

If I had my way, the bug link would be aligned to the bottom right corner instead of the top right.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.