[Webkit-unassigned] [Bug 50098] New webkit-patch rebaseline2 command.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 8 18:19:10 PST 2010


--- Comment #32 from Dirk Pranke <dpranke at chromium.org>  2010-12-08 18:19:09 PST ---
After a decently-long IM conversation w/ James, I've reached the conclusion that what his code is trying to do is different enough from what the code under layout_tests is designed to do that merging the two will be non-trivial.

Where easy, he should use (and add to) the Port abstractions for now, but we need to step back and come up with a common design that works for both run-webkit-tests (which wants to pretend that all it knows about are test names, and test output, and knows nothing about files) and the rebaselining tools (which only knows about filenames and has to try and reconstruct how they map onto test names and outputs).

A resulting design will probably affect, in addition to James' code:

layout_tests/port/* (the methods dealing with test name conversions and expectations, at least)

the work Ito-san is doing with reftests.

However, all that stuff is down the road and shouldn't hold up this patch. I will take another look later at the code, with that in mind, but since I'm not a reviewer, someone else should review this bearing what I've just written in mind.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list