[Webkit-unassigned] [Bug 50726] Need a way to get a WKBundleFrameRef from JS HTMLIFrameElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50726


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75996|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2010-12-08 17:53:39 PST ---
(From update of attachment 75996)
View in context: https://bugs.webkit.org/attachment.cgi?id=75996&action=review

> WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:63
> +    PassRefPtr<WebFrame> copyDocumentFrame();
> +    PassRefPtr<WebFrame> copyHTMLFrameElementContentFrame();
> +    PassRefPtr<WebFrame> copyHTMLIFrameElementContentFrame();

When the return type is a PassRefPtr, I’m not sure it makes all that much sense to use copy naming when there’s no actual copying going on. There’s no need to use the copy rule for naming when you have a smart pointer class involved.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.