[Webkit-unassigned] [Bug 33435] selection.modify("move", "left", "lineboundary") in RTL text moves to the right lineboundary

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33435





--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org>  2010-12-08 16:54:04 PST ---
(From update of attachment 75845)
View in context: https://bugs.webkit.org/attachment.cgi?id=75845&action=review

>> WebCore/editing/SelectionController.cpp:432
>> +        break;
> 
> We should just do:
> if (directionOfEnclosingBlock() == LTR)
>     return visualEndOfLine(startForPlatform());
> return visualStartOfLine(startForPlatform());
> 
> and modify
> pos = modifyMovingForward(granularity);
> to
> return modifyMovingForward(granularity);
> 
> I don't know why we have a VisiblePosition local variable in the first place.

I'm confused about this change now.  Why are we calling different visual* functions depending on the directionality of text block?  Shouldn't visualStartOfLine always return the visually left-most offset?  When we say the start of line in RTL text, is it the right edge of the text?  Because your change seems to indicate that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.