[Webkit-unassigned] [Bug 25057] remove rangeCompliantEquivalent and replace it with Position methods

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25057





--- Comment #11 from Ryosuke Niwa <rniwa at webkit.org>  2010-12-08 11:31:25 PST ---
(From update of attachment 75931)
View in context: https://bugs.webkit.org/attachment.cgi?id=75931&action=review

Sorry, I keep noticing something new.

> WebCore/dom/Position.cpp:157
> +    // Handle quirks with tables and legacy positions offsets
> +    if (m_offset <= 0) {

On my second thought, shouldn't we also check that it's a legacy position?  m_offset <= 0 is also true when m_anchorType != PositionIsOffsetInAnchor, no?

> WebCore/dom/Position.cpp:162
> +    if (!m_anchorNode->offsetInCharacters() && static_cast<unsigned>(m_offset) == m_anchorNode->childNodeCount()

Ditto here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.