[Webkit-unassigned] [Bug 25057] remove rangeCompliantEquivalent and replace it with Position methods

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25057





--- Comment #9 from Levi Weintraub <leviw at google.com>  2010-12-08 10:28:04 PST ---
(In reply to comment #8)
> (From update of attachment 75917 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75917&action=review
> 
> > WebCore/dom/Position.cpp:160
> > +        return Position(m_anchorNode, 0);
> 
> Oops, this would create a legacy Position object.  You need to explicitly pass PositionIsOffsetInAnchor as in Position(m_anchorNode, 0, PositionIsOffsetInAnchor); to create a non-legacy Position object.
> 
> > WebCore/dom/Position.cpp:167
> > +    return Position(containerNode(), computeOffsetInContainerNode());
> 
> Ditto.

You're right, missed that somehow. Trying again :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.