[Webkit-unassigned] [Bug 46895] [Chromium] Implement mocks for client-based geolocation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46895





--- Comment #24 from Steve Block <steveblock at google.com>  2010-12-08 09:38:49 PST ---
(From update of attachment 75813)
View in context: https://bugs.webkit.org/attachment.cgi?id=75813&action=review

LGTM

> WebKit/chromium/src/WebGeolocationClientMock.cpp:63
> +    WebGeolocationError::Error code = WebGeolocationError::ErrorPositionUnavailable;

I'd prefer an assert to a default value for test code, but it's really just personal preference.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.