[Webkit-unassigned] [Bug 50098] New webkit-patch rebaseline2 command.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 7 22:00:04 PST 2010


--- Comment #26 from James Kozianski <koz at chromium.org>  2010-12-07 22:00:04 PST ---
(In reply to comment #18)
> (In reply to comment #7)
> > > > WebKitTools/Scripts/webkitpy/tool/commands/rebaseline2.py:53
> > > > +            make_option("--chromium", action="store_true", dest="use_chromium_bots", help="Fetch results from the Chromium bots."),
> > > 
> > > Boo.  We should use --port to specify the port instead of making a magic special case for Chromium.
> > 
> > Sorry, I was imitating build-webkit's --chromium flag here. I've added Port.buildbot_resultset() so the buildbots used are controlled via the port.
> >
> Well, --platform, actually, not --port, but otherwise I agree that these switches probably don't make sense in this context.
> --chromium is useful in the run-webkit-tests case because we run on multiple operating systems, and so it enables scripts to specify that they want the chromium version regardless of what operating system is actually running.
> Adam was half jesting, but one could almost argue that --webkit might make sense for the same reason, if you were attempting to define --webkit as (mac|win). But those two ports are different enough from each other that even the Apple guys don't tend to think of them that way AFAIK.

I'm currently using the --platform*s* flag to specify what platforms to retrieve new baselines for - are you okay with --platform and --platforms existing?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list