[Webkit-unassigned] [Bug 47311] Add layout tests for Entry.getMetadata (FileSystem API)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47311





--- Comment #7 from Kinuko Yasuda <kinuko at chromium.org>  2010-12-07 18:28:48 PST ---
(From update of attachment 71481)
View in context: https://bugs.webkit.org/attachment.cgi?id=71481&action=review

>> LayoutTests/fast/filesystem/resources/op-tests-helper.js:223
>> +                var entryMetadataString = 'this.environment["' + symbol + '"]';
> 
> Might be better to make 'this.environment["' + symbol + '"]' a helper function in order to simplify the code.

Done.

>> LayoutTests/fast/filesystem/resources/op-tests-helper.js:230
>> +                this.errorCallback();
> 
> Probably we should continue to run next test even we fail the current test unless we encounter a severe error that cannot be recoverable,

Done.

>> LayoutTests/fast/filesystem/resources/op-tests-helper.js:232
>> +         };
> 
> '}' not aligned correctly.

Fixed.

>> LayoutTests/fast/filesystem/resources/op-tests-helper.js:324
>> +         };
> 
> ditto.

Fixed.

>>>>> LayoutTests/fast/filesystem/resources/op-tests-helper.js:331
>>>>> +            // Record rounded start date (current time minus 999 msec) here for the comparison. Entry.getMetadata() may return motd in seconds accuracy while new Date() is milliseconds accuracy.
>>>> 
>>>> What is motd?
>>> 
>>> Why would getMetadata be so inaccurate?  Is that a filesystem limitation or part of our implementation?
>> 
>> Ouch I think I meant mod time (last modification time).  Will fix in the next patch.
> 
> Well, there's no requirement that it be any more accurate than that.  I was just curious.

Fixed the comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.