[Webkit-unassigned] [Bug 47142] Spatial navigation not Working for Map and Area Tags

Tue Dec 7 06:57:43 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=47142

Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75631|review?                     |review+
               Flag|                            |

--- Comment #18 from Antonio Gomes <tonikitoo at webkit.org>  2010-12-07 06:57:43 PST ---
(From update of attachment 75631)
View in context: https://bugs.webkit.org/attachment.cgi?id=75631&action=review

> WebCore/page/SpatialNavigation.h:123
> +    Node* visibleNode;
>      Node* enclosingScrollableBox;
> +    Node* focusableNode;

Please add a comment in the code explaining the difference between visibleNode and focusableNode, and when to use one or the other.

I would also like to see asserts in the code if one is trying to use one, but should be using the other.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.