[Webkit-unassigned] [Bug 49714] Yensign hack should work with Shift_JIS encoding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49714


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74536|review?                     |review+
               Flag|                            |




--- Comment #22 from Alexey Proskuryakov <ap at webkit.org>  2010-12-06 20:55:28 PST ---
(From update of attachment 74536)
View in context: https://bugs.webkit.org/attachment.cgi?id=74536&action=review

> WebCore/ChangeLog:10
> +        IE chooses a font which shows a yensign for 0x5c code point for a page
> +        encoded in x-mac-japanese, ISO-2022-JP, EUC-JP, Shift_JIS, Shift_JIS_X0213-2000,
> +        x-sjis, and Windows-31J.

I thought IE didn't support Shift_JIS_X0213-2000.

> WebCore/ChangeLog:16
> +        Also, we move the HashSet initialization for isJapanese() and
> +        backslashAsCurrencySymbol() to TextEncodingRegistry.cpp because of
> +        ease of making them multi-thread safe.

This is not a great reason - TextEncodingRegistry does not and should not care about backslashes.

> WebCore/platform/text/TextEncoding.cpp:166
>  bool TextEncoding::isJapanese() const

This function is misplaced - all it is needed for is to make a decision on whether to invoke charset detection. So it should be in TextResourceDecoder (not something for this patch, of course).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.