[Webkit-unassigned] [Bug 50607] New: Remove stale include of Document.h in V8DOMWrapper.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50607

           Summary: Remove stale include of Document.h in V8DOMWrapper.h
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: creis at chromium.org
                CC: japhet at chromium.org, vitalyr at chromium.org


An include of Document.h was added to V8DOMWrapper.h in http://trac.webkit.org/changeset/47921, but it appears this is no longer needed since the convertNodeToV8Object function that was using it is gone.  (Same for the include of V8DOMMap.h.)

I'd like to remove the stale include(s) to avoid a circular include chain introduced by the combination of Nate Chapin's change to Document.h (http://trac.webkit.org/changeset/73392) and my pending patch to NavigationAction.h (https://bugs.webkit.org/attachment.cgi?id=75044&action=review).

Specifically, after Nate includes DocumentLoader from Document and I include HistoryItem from NavigationAction, it's possible for V8DOMWrapper to transitively include V8Proxy.  That leads to this compile error:

  CXX(target) out/Debug/obj.target/webcore_bindings/gen/webkit/bindings/V8DerivedSources8.o
In file included from third_party/WebKit/WebCore/bindings/v8/ScriptValue.h:41,
                 from third_party/WebKit/WebCore/bindings/v8/SerializedScriptValue.h:34,
                 from third_party/WebKit/WebCore/history/HistoryItem.h:31,
                 from third_party/WebKit/WebCore/loader/NavigationAction.h:34,
                 from third_party/WebKit/WebCore/loader/DocumentLoader.h:34,
                 from third_party/WebKit/WebCore/dom/Document.h:36,
                 from third_party/WebKit/WebCore/bindings/v8/V8DOMWrapper.h:34,
                 from out/Debug/obj/gen/webkit/bindings/V8BeforeProcessEvent.h:25,
                 from out/Debug/obj/gen/webcore/bindings/V8BeforeProcessEvent.cpp:22,
                 from out/Debug/obj/gen/webkit/bindings/V8DerivedSources3.cpp:31:
third_party/WebKit/WebCore/bindings/v8/V8Proxy.h: In static member function '€˜static v8::Handle<v8::Value> WebCore::V8Proxy::constructDOMObject(const v8::Arguments&, WebCore::WrapperTypeInfo*)'€™:
third_party/WebKit/WebCore/bindings/v8/V8Proxy.h:362: error: '€˜V8DOMWrapper'€™ has not been declared
third_party/WebKit/WebCore/bindings/v8/V8Proxy.h:364: error: '€˜V8DOMWrapper'€™ has not been declared

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.