[Webkit-unassigned] [Bug 50115] Please implement async=false for dynamic script loading (REGRESSION: LABjs is broken)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 6 16:21:34 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=50115





--- Comment #28 from James Simonsen <simonjam at chromium.org>  2010-12-06 16:21:33 PST ---
(In reply to comment #26)
> (From update of attachment 75523 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75523&action=review
> 
> > LayoutTests/fast/dom/HTMLScriptElement/resources/big.js:3
> > +    About 16KB to make this resource load slowly.
> 
> I'm not sure if this will reliably check your condition (although it won't be flaky). Did you consider making this an http test with a php/cgi resource that sleeps before returning? That is what some other script ordering tests do.

No, but that's exactly what I wanted. I've moved it to an http/ test.

> > LayoutTests/fast/dom/HTMLScriptElement/script-async-attr.html:17
> > +<script id="s7" async></script>
> 
> We should also test <script id="s8" async="false"></script>

Added. It's counter-intuitive, but it matches the old behavior.

> > WebCore/dom/ScriptRunner.cpp:1
> > +/*
> 
> It is really difficult to review a rename with changes to the renamed file in the same patch. Is it too much trouble to ask to separate them?

I changed the options to git diff so that it detects renamed files.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list