[Webkit-unassigned] [Bug 50581] Make TestResultsServer return empty JSON or 404 for non-existing results files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50581





--- Comment #9 from Kinuko Yasuda <kinuko at chromium.org>  2010-12-06 15:42:54 PST ---
(In reply to comment #6)
> Looks like a webkit bug. At first glance, it seems we don't fire the error event for a 404 if the file contents are empty. Firefox fires the error event in this case. As a workaround, on the JS side, we can listen to the load event as well and check if the script is empty, e.g., 
> 
> <script
>   id="foo" 
>   src="http://test-results-test.appspot.com/testfile?builder=Linux%20Builder%20(Views%20dbg)&master=Chromium&testtype=unit_tests&name=results.json"
>   onload="alert('innerHTML=\'' + document.getElementById('foo').innerHTML + '\'');"
>   onerror="alert('error')"></script>
> 
> Eventually, we can fix the webkit bug and won't need this anymore.

Interesting.  onload work-around seemed to work.
I updated the patch just to return 404.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.