[Webkit-unassigned] [Bug 50400] [Web Timing] Add handshakeStart to interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50400





--- Comment #5 from James Simonsen <simonjam at chromium.org>  2010-12-06 15:16:56 PST ---
(In reply to comment #4)
> (From update of attachment 75541 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75541&action=review
> 
> > LayoutTests/http/tests/misc/webtiming-ssl-expected.txt:1
> > +This test checks that Web Timing reports handshakeStart correctly and has reasonable values for connectStart and connectEnd. Note that DumpRenderTree doesn't set handshakeStart.
>
> Thanks for adding the test even though it fails. We should probably open a bug to track this.

Done. https://bugs.webkit.org/show_bug.cgi?id=50592

> > WebCore/page/PerformanceTiming.cpp:-190
> > -        connectStart = timing->dnsEnd;
> 
> It isn't clear to me why this is removed. Trimming DNS seems unrelated to trimming SSL. If it is correct, a better explanation in the ChangeLog is probably warranted.

Reverted. I must've misunderstood the comment or something. Clearly the original code is correct.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.