[Webkit-unassigned] [Bug 50299] webkit-patch needs land-no-bug

Mon Dec 6 12:28:50 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=50299

--- Comment #14 from Ojan Vafai <ojan at chromium.org>  2010-12-06 12:28:50 PST ---
(In reply to comment #6)
> > Is there a benefit of land-cowboy not running check-style?
> 
> It's faster and it doesn't complain when you make style errors.  Cowboys don't care about style errors.

Coming back to this...I still don't see the point. By that argument, why do we even confirm the diff? Check-style is fast, no? Anyways, you can do:

webkit-patch land-cowboy --ignore-style

I could just add my own command of course, but I don't agree that the cost is low just because it's hidden by default. Chromium webkit gardeners need to use this command frequently and, for that case style checking by default is especially important so that test_expectations changes get checked to avoid breaking the bots.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.