[Webkit-unassigned] [Bug 50527] [Qt] Background image rendering is slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50527





--- Comment #11 from Noam Rosenthal <noam.rosenthal at nokia.com>  2010-12-06 08:06:58 PST ---
(In reply to comment #5)
> (From update of attachment 75618 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75618&action=review
> 
> > WebCore/platform/graphics/qt/ImageQt.cpp:139
> > +    painter->drawTiledPixmap(QRect(0, 0, destinationRect.right() - offset.x(), destinationRect.bottom() - offset.y()), tilePixmap);
> 
> I don't understand the coordinates here. Why you start at 0, 0? Why the width is destinationRect.right() - offset.x()? The offset could be bigger than destinationRect.right(), and the result should still be correct.

Since we translate(offset) a line earlier, this would draw the tile pixmap between the points 
(offset -> destinationRect.bottomRight()). Maybe I need to write it in a more verbose way :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.