[Webkit-unassigned] [Bug 50380] Implement "required" attribute for select tags

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 6 04:09:17 PST 2010


--- Comment #19 from Dai Mikurube <dmikurube at google.com>  2010-12-06 04:09:17 PST ---
(In reply to comment #15)
> Oh, your understanding of the current code is correct.
> I found the current code is wrong.  If willValidate is false, ValidityState::valueMissing() should return false and we should not call HTMLSelectElement::valueMissing().  Each of exposed functions of ValidityState should check willValidate() at their beginning like ValidityState::validationMessage() is doing.
> Would you fix ValidityState::valueMissing() in this bug, and fix other functions of ValidityState in another bug please?

Ok, I'll fix them in this and another bugs.

(In reply to comment #16)
> isValidValue() was introduced in orde that browsers can set valid values by their auto-fill / completion features.  Setting valid value to <select> is easy because it's just setting an index, and checking a string value doesn't make much sense.

Thanks, I understand. Keep it removed.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list