[Webkit-unassigned] [Bug 49904] [GTK] Add a signal to allow applications to handle its own context menu

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49904





--- Comment #5 from Gustavo Noronha (kov) <gns at gnome.org>  2010-12-06 03:38:10 PST ---
(From update of attachment 75018)
View in context: https://bugs.webkit.org/attachment.cgi?id=75018&action=review

A few comments: in general, I like the patch. Epiphany replaces the context menu completely by using a different technique, though: handling the right-clicks that should cause a context menu to appear itself, and then showing the menu it creates if the page doesn't claim the right click. That said, it was a pain to get the behaviour right, and having a separate signal could make life simpler for other applications, so +1 from me. I'd like to hear what Xan thinks, though.

> WebKit/gtk/webkit/webkitwebview.h:147
> +    gboolean                   (*context_menu)            (WebKitWebView        *web_view,
> +                                                           gint                  x,
> +                                                           gint                  y,
> +                                                           gboolean              keyboard_mode,
> +                                                           WebKitHitTestResult  *hit_test_result);

This breaks ABI, I would suggest adding the signal and avoiding the virtual method.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.