[Webkit-unassigned] [Bug 45443] [GTK] Support for viewport meta tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45443


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74400|review?                     |review-
               Flag|                            |




--- Comment #66 from Gustavo Noronha (kov) <gns at gnome.org>  2010-12-06 03:06:39 PST ---
(From update of attachment 74400)
View in context: https://bugs.webkit.org/attachment.cgi?id=74400&action=review

I believe this is good to go, now. Let's just fix the Since tags, and see if we can test it using the signal instead of the new DRTSupport function.

> WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:91
> +// For testing fast/viewport.
> +void DumpRenderTreeSupportGtk::computeViewportAttributesForSize(WebKitWebView* webView, gint availableWidth, gint availableHeight)
> +{
> +    g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));
> +
> +    ViewportArguments arguments = webView->priv->corePage->mainFrame()->document()->viewportArguments();
> +    // desktopWidth = 980, deviceWidth = 320, deviceHeight = 480, deviceDPI = 160
> +    ViewportAttributes attrs = computeViewportAttributes(arguments, 980, 320, 480, 160, IntSize(availableWidth, availableHeight));
> +
> +    fprintf(stdout, "viewport size %dx%d scale %f with limits [%f, %f]\n", attrs.layoutSize.width(), attrs.layoutSize.height(), attrs.initialScale, attrs.minimumScale, attrs.maximumScale);
> +}

With the API we have now, all of the values used in this call can be overriden by handling the signal, can't they? If that is the case, I think it would be much more interesting to use the signal for the test =)

> WebKit/gtk/webkit/webkitwebview.cpp:2913
> +    * Since: 1.3.5

All of these should now be 1.3.8 =)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.