[Webkit-unassigned] [Bug 48821] Let HTMLObjectElement be a form associated element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48821





--- Comment #29 from Kenichi Ishibashi <bashi at google.com>  2010-12-05 22:54:38 PST ---
(From update of attachment 75593)
View in context: https://bugs.webkit.org/attachment.cgi?id=75593&action=review

Kent-san,

Thank you for review. I'll post revised patch in a minute.

>> WebCore/html/FormAssociatedElement.cpp:55
>> +static HTMLFormElement* findFormOwner(HTMLElement* element)
> 
> This function is very similar to HTMLElement::findFormAncestor().  We had better unify them, or should name this findFormAncestor() too.

To unify them, I removed findFormOwner() and changed the access level of HTMLElement::findFormAncestor() from protected to public. Exposing findFormAncestor() might be controversial so please r- if you have objections.

>> WebCore/html/HTMLFormCollection.cpp:116
>> +            && element->getAttribute(attrName) == name) {
> 
> You don't need to wrap the line.

Done.

>> WebCore/html/HTMLFormControlElement.h:58
>> +    virtual void setDisabled(bool);
> 
> Do we need to add "virtual"?

Removed.

>> WebCore/html/HTMLFormElement.cpp:221
>> +            static_cast<HTMLFormControlElement*>(m_associatedElements[i])->hideVisibleValidationMessage();
> 
> We should add { } to the "for" because the content has two physical lines.

Done.

>> WebCore/html/HTMLFormElement.cpp:357
>> +            static_cast<HTMLFormControlElement*>(m_associatedElements[i])->reset();
> 
> ditto.

Done.

>> WebCore/html/HTMLFormElement.cpp:652
>> +            static_cast<HTMLFormControlElement*>(m_associatedElements[i])->reset();
> 
> ditto.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.