[Webkit-unassigned] [Bug 47142] Spatial navigation not Working for Map and Area Tags

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47142


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1




--- Comment #16 from Antonio Gomes <tonikitoo at webkit.org>  2010-12-05 07:27:16 PST ---
(In reply to comment #15)
> (In reply to comment #14)
> Thanks for he review, Antonio.
> 
> > I do not like the special case you gave for area elements. Maybe we should have a FocusCandidate.isAreaElement() method instead and handling the changes accordingly. It is very implicit for who read the code what or when use 'node' instead of 'actualNode' , and vice-versa.
> > 
> > Could we try something to improve this?
> I agree that node and actualNode are poor choice for names. How about if we turn FocusCandidate into a class with 2 accessor functions: visibleNode() and focusableNode() ?

I think these (better names) would be the code more readable, Yael. 

> If we add FocusCandidate.isAreaElement(), the logic of handling HTMLAreaElements would be spread through the spatial navigation code instead of being encapsulated in FocusCandidate, which is what I was trying to do.
> 
> 
> > > WebCore/page/SpatialNavigation.cpp:701
> > > +    IntRect rect = virtualRectForDirection(direction, rectToAbsoluteCoordinates(area->document()->frame(), area->getRect(area->imageElement()->renderer())), 1);
> >

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.