[Webkit-unassigned] [Bug 47142] Spatial navigation not Working for Map and Area Tags

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47142





--- Comment #14 from Antonio Gomes <tonikitoo at webkit.org>  2010-12-04 20:20:18 PST ---
(From update of attachment 75591)
View in context: https://bugs.webkit.org/attachment.cgi?id=75591&action=review

Looks fine, but we might be able to make it better. Lets see answers for some comments and questions I have before go for it.

> WebCore/page/FocusController.cpp:480
> +            if (!node->isKeyboardFocusable(event))
> +                continue;

Lets make one the two checks for !node->isKeyboardFocusable(event) in a follow up.

> WebCore/page/SpatialNavigation.cpp:87
> +    actualNode = area;
> +    node = image;

I do not like the special case you gave for area elements. Maybe we should have a FocusCandidate.isAreaElement() method instead and handling the changes accordingly. It is very implicit for who read the code what or when use 'node' instead of 'actualNode' , and vice-versa.

Could we try something to improve this?

> WebCore/page/SpatialNavigation.cpp:701
> +    IntRect rect = virtualRectForDirection(direction, rectToAbsoluteCoordinates(area->document()->frame(), area->getRect(area->imageElement()->renderer())), 1);

Could you please explain the '1' with other words here. I did not follow it :(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.