[Webkit-unassigned] [Bug 48821] Let HTMLObjectElement be a form associated element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48821





--- Comment #26 from Kenichi Ishibashi <bashi at google.com>  2010-12-03 19:39:38 PST ---
Kent-san, Darin,

Thank you for your suggestions and comments. I'll update the patch following your comments.

(In reply to comment #25)
> (In reply to comment #24)
> > IMO, it's ok to split these flags into two classes.
> 
> I agree, but also, if we do decide to put all the flags in one class to try to save memory, we should use the pattern from Node/Element and not expose the public access to the flags until the class they belong on.
> 
> > BTW, do we really need to put validation members to FormAssociatedElement? <object> needs to have a ValidityState object, but other validation flags should be constant in <object>.
> 
> It’s useful to keep the FormAssociatedElement class minimal.
> 
> > HTML5 spec says the type attribute must be a valid MIME type (http://dev.w3.org/html5/spec/the-iframe-element.html#attr-object-type). That's why I tried to return m_serviceType here.
> 
> Sure, that’s the type attribute of HTMLObjectElement. I’m not sure FormAssociatedElement needs a type attribute at all.
> 
> > Do we need formControlType() in FormAssociatedElement?  I think we can remove type() and formControlType() from FormAssociatedElement.  We had better minimize the number of methods of FormAssociatedElement.
> 
> I agree.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.