[Webkit-unassigned] [Bug 46283] Allow CSS animations to run at more than 40FPS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46283


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69599|review?                     |review-
               Flag|                            |




--- Comment #7 from Eric Seidel <eric at webkit.org>  2010-12-03 13:39:34 PST ---
(From update of attachment 69599)
View in context: https://bugs.webkit.org/attachment.cgi?id=69599&action=review

> WebCore/page/Settings.h:204
> +        static void setMinDOMTimerInterval(double); // Interval specified in seconds.        
> +        static void setAnimationTimerDelay(double); // Timer delay specified in seconds.

Comments are strictly worse than code.  Please include the units in the code, and then you don't need the "seconds" comment.

Example:
void setAnimationTimerDelay(double seconds)
would be better, but:

void setAnimationTimerDelaySeconds(double); woudl be even better!

> WebKit/qt/Api/qgraphicswebview.cpp:250
> +    Settings::setAnimationTimerDelay(0.0167);

This constant would be much clearer if documented, and ideally computed from values more human readable.

Also, this method would be much clearer if it mentioned the units in question.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.