[Webkit-unassigned] [Bug 50451] [GTK] Drop GdkDrawable usage, it's deprecated in GTK+3.x and we can use GdkWindow

Fri Dec 3 12:58:56 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=50451

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75504|review?                     |review+
               Flag|                            |

--- Comment #9 from Martin Robinson <mrobinson at webkit.org>  2010-12-03 12:58:56 PST ---
(From update of attachment 75504)
View in context: https://bugs.webkit.org/attachment.cgi?id=75504&action=review

I tested this patch locally with exceptional results. But unless I'm crazy, I think that the change to the comment is incorrect.

> WebCore/platform/gtk/WidgetRenderingContextGtk2.cpp:91
> +    // paint directly to the target window. This will not render CSS rotational transforms properly.

This comment is actually correct, because m_target may either be a GdkWindow or a GdkPixmap, both of which are drawables. I don' think a pixmap is a window though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.