[Webkit-unassigned] [Bug 50331] ASSERT failing restoring scroll position from HistoryItem after reload

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50331


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75287|review?                     |review-
               Flag|                            |




--- Comment #4 from Eric Seidel <eric at webkit.org>  2010-12-03 10:30:27 PST ---
(From update of attachment 75287)
View in context: https://bugs.webkit.org/attachment.cgi?id=75287&action=review

This needs a test.

> WebCore/loader/FrameLoader.cpp:2408
> +            // If the user had a scroll point, scroll to it,
> +            // overriding the anchor point if any. Also, make sure
> +            // there's a valid current item in the history before
> +            // trying to scroll because it could happen there was none
> +            // (e.g. loading from a string instead of an URI).
> +            if (m_frame->page() && history()->currentItem()) {

Seems rather overzealous line wrapping. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.