[Webkit-unassigned] [Bug 50396] REGRESSION(r72783): DOMActivate fires multiple times from input type=file

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50396


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75502|review?                     |review+
               Flag|                            |




--- Comment #6 from Darin Adler <darin at apple.com>  2010-12-03 09:36:04 PST ---
(From update of attachment 75502)
View in context: https://bugs.webkit.org/attachment.cgi?id=75502&action=review

> WebCore/dom/Node.cpp:1205
> +    if (!node)
> +        return false;
> +    if (this == node)
> +        return true;
> +    for (ContainerNode* n = node->parentOrHostNode(); n; n = n->parentOrHostNode()) {
> +        if (n == this)
> +            return true;
> +    }
> +    return false;

I like the way you wrote this, but I would have written it this way:

    for (Node* n = node; n; n = n->parentOrHostNode()) {
        if (n == this)
            return true;
    }
    return false;

No need for the special handling of the node itself.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.