[Webkit-unassigned] [Bug 50430] [GTK] The webkit cache model needs to be set when WebFrameLoaderClient::didPerformFirstNavigation() is called

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50430





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2010-12-03 07:00:11 PST ---
(From update of attachment 75449)
View in context: https://bugs.webkit.org/attachment.cgi?id=75449&action=review

> WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:696
> +    if (cacheModel != WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER && cacheModel != WEBKIT_CACHE_MODEL_WEB_BROWSER)

I think it makes sense to expalin this logic with a comment. The Mac port explictly tracks whether or not an API consumer has set a cache model via the  automaticallyDetectsCacheModel setting. That might provide a self-documenting alternative.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.