[Webkit-unassigned] [Bug 50380] Implement "required" attribute for select tags

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 3 05:02:40 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=50380





--- Comment #10 from Dai Mikurube <dmikurube at google.com>  2010-12-03 05:02:41 PST ---
(From update of attachment 75465)
View in context: https://bugs.webkit.org/attachment.cgi?id=75465&action=review

>>> WebCore/html/HTMLSelectElement.cpp:115
>>> +    if (!isRequiredFormControl() || disabled() || multiple() || size() > 1)
>> 
>> We don't need to check disabled() here.  It's responsibility of willValidate().
>> 
>> We should not return false for multiple() unconditionally.  The specification says we never have placeholder label option for multiple, but required should work with multiple.
> 
> Thanks, the code is wrong. Revised.

wilValidate() is checked at checkValidity(), but not checked when directly reading properties validity.*. So it is required to check disable() (or willValidate()) here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list