[Webkit-unassigned] [Bug 50382] [GStreamer] hasVideo/Audio return false until the pipeline reaches PAUSED

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50382





--- Comment #5 from Philippe Normand <pnormand at igalia.com>  2010-12-03 02:17:12 PST ---
(In reply to comment #4)
> (From update of attachment 75381 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75381&action=review
> 
> Seems reasonable, but please remove the unecessary lines from the destructor.
> 
> > WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:396
> > +    m_videoTagsTimerHandler = 0;
> 
> You shouldn't need to zero this field out in the destructor.
> 
> > WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:400
> > +    m_audioTagsTimerHandler = 0;
> 
> Same here.

Hum ok but why did you approve the similar changes for the mute/volume timer handlers? :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.