[Webkit-unassigned] [Bug 50434] Marquee elements do not stop animating when scrollAmount is set to 0.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 3 00:38:30 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=50434





--- Comment #4 from Andy Estes <aestes at apple.com>  2010-12-03 00:38:31 PST ---
(In reply to comment #3)
> (From update of attachment 75460 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75460&action=review

Thanks for the feedback David.
> 
> A few comments.
> 
> > WebCore/rendering/RenderMarquee.cpp:297
> > +        int increment = abs(m_layer->renderer()->style()->marqueeIncrement().calcValue(clientSize));
> 
> Why not just change the 1 to a 0?

It seems more concise to remove the call to max() entirely since an absolute value can't possibly be less than 0.

> 
> > LayoutTests/fast/html/marquee-scrollamount.html:13
> > +        // Marquee's default scrollDelay is 85ms, so wait for 100ms to ensure
> 
> Why no change the scrollDelay to 0 and then wait a shorter time?
> 
> 100ms doesn't seem long but it adds up over lots of tests.

Good idea. I can mke that change before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list