[Webkit-unassigned] [Bug 50366] XPath lexer misinterprets expression starting with "div".
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 2 20:59:53 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=50366
Yonathan Randolph <yonathan at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #75461| |review?
Flag| |
--- Comment #5 from Yonathan Randolph <yonathan at gmail.com> 2010-12-02 20:59:53 PST ---
Created an attachment (id=75461)
--> (https://bugs.webkit.org/attachment.cgi?id=75461&action=review)
Updated patch with exhaustive test and slight bug fix.
I've done what you've asked for.
> - if (isOperatorContext()) {
> + if (isBinaryOperatorContext()) {
> if (name == "and") //### hash?
> return Token(AND);
>
> I'm wondering what this ### comment is about.
I don't understand it either.
> I'd try to add as many tests as I can think of, even if redundant. Say, "div/div", "(12) div 4" or "div + div".
I've begrudgingly made the test exhaustive (I think). Turns out this was actually a good idea, because I found a case I didn't notice earlier: node test immediately following comma.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list