[Webkit-unassigned] [Bug 50098] New webkit-patch rebaseline2 command.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50098





--- Comment #21 from Dirk Pranke <dpranke at chromium.org>  2010-12-02 18:33:02 PST ---
(In reply to comment #16)
> Maybe we can use the term 'baseline' to mean the thing that this class represents, ie: something that the output of a test can be compared against to determine PASS/FAIL?
> 
> That seems to fit with the general phrase 'rebaselining' - it's taking baselines from builders and using them to overwrite our existing baselines. What do you think?
>

I'm not a huge fan of this approach, because you get the concepts of "expected baseline" and "actual baseline", one of which seems like an oxymoron and the other redundantly redundant.

I think "output" is my favorite candidate so far, but admittedly it's not great either.

Also, I forgot to mention that I can't see ResultSet without thinking about JDBC and ODBC, but maybe that's just me ... I haven't thought of anything better yet as an alternative.

> > 
> > I've been trying to morph the layout tests code into using something a bit more consistent, so we should line things up here if we can. I would prefer something like "TestOutput" here.
> 
> Could you be a bit more specific? How could I change Results to be more suitable?
>

Unfortunately, not at the moment, as I haven't really even started to play with these ideas yet. Hopefully more next week. I need to stare more at how you're using Result to think about commonalities and differences.

> > Also, the work we're doing with reftests will impact this as well, so it would be good to get up to speed on that if you aren't already (and I've cc'ed Ito-san on this to make sure he's aware of it as well).
> 
> I'm not familiar with reftests. Could you point me to somewhere I could learn more about them?

reftests are the idea that foo.html should render exactly like foo-expected.html (the "reference" version). They allow you to write a large class of tests that can stay pretty platform-independent (for example, because both tests will draw scroll bars the same way). Mozilla uses them pretty extensively. 

They don't replace every kind of pixel test, though.

Ito-san is working on adding support to NRWT for them. See bug 36065 for more info and references to design, Mozilla's docs, etc.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.