[Webkit-unassigned] [Bug 50365] Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Linux and Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50365


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75437|1                           |0
        is obsolete|                            |




--- Comment #6 from Eric Seidel <eric at webkit.org>  2010-12-02 17:34:42 PST ---
(From update of attachment 75437)
View in context: https://bugs.webkit.org/attachment.cgi?id=75437&action=review

You need AGL's or evmar's review here.  But testing is the major failing of this patch.  Please clarify which tests cover this and ideally include the updated results.

> WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

This will cause the cq to fail.  You should mention which tests this affects.

> WebCore/platform/graphics/chromium/FontLinux.cpp:106
> +            pos2[i].set(x + SkFloatToScalar(adv[i].width()), y);
> +            pos3[i].set(x + SkFloatToScalar(adv[i].width()), y-SkFloatToScalar(adv[i].width())); 

Seems we could use a local here to save about 50 chars of typing. :)

> WebCore/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:68
> +        if (hbFace->gsub) {
> +            HB_Buffer buffer;

Either early return or using a helper function for this big clause would make this clearer.

> WebCore/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:81
> +                // FIXME : how/what to do 

This isn't a very helpful fixme (nor is it a complete sentence with capital and period).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.