[Webkit-unassigned] [Bug 48242] check-webkit-style: false positive reported for #if macro

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 2 17:24:40 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=48242





--- Comment #2 from Eric Seidel <eric at webkit.org>  2010-12-02 17:24:39 PST ---
(From update of attachment 75440)
View in context: https://bugs.webkit.org/attachment.cgi?id=75440&action=review

Otherwise seems fine.

> WebKitTools/Scripts/webkitpy/style/checkers/cpp.py:1461
> +            in_preprocessor_directive = match(r'\s*#', line)

Seems you want a ^ in that regexp to lock it to the front of the string.

char* my_invalid_style = "You're #1\n"'; would trigger that regexp even though it shouldn't.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list