[Webkit-unassigned] [Bug 50385] [Qt] Make platform managing of OSAllocator better than r73106

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50385





--- Comment #11 from Geoffrey Garen <ggaren at apple.com>  2010-12-02 13:34:09 PST ---
I talked this over with some other folks, and the rough consensus was:

- Separating completely different platform implementations into different .cpp files is good;
- Surrounding a file like OSAllocatorWin.cpp with "#if OS(WINDOWS)" is not terribly harmful, so we're willing to do it if it makes some build systems simpler;
- However, building more than one platform implementation file (for example, OSAllocatorWin.cpp and OSAllocatorPosix.cpp) in the same build system is not recommended practice.

Ultimately, this probably argues against the #ifdef changes in r73179. I don't think there's an immediate need to roll them out, however, going forward, I think Laszlo is right that we should keep platform-specific implementation files #ifdef'd.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.