[Webkit-unassigned] [Bug 50386] Event::fromUserGesture() should be based on Event creation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50386





--- Comment #3 from Kristian Monsen <kristianm at google.com>  2010-12-02 12:53:18 PST ---
(In reply to comment #2)
> Shouldn't the "other call stack" just have UserGestureIndicator::processingUserGesture() respond appropriately?
> 
> It's best to implement unusual single platform features in a way that doesn't require modifications to core WebKit, as otherwise we'd keep unknowingly breaking them.

Hi Alexey, thanks for the review!

I didn't think it was Android related, which is why I wanted reviews here without Android guards. We are using V8, so I am quite sure it can be reproduced on other V8 platforms as well.

You are right that there are other solutions, but this should at least always be correct? To do it they way you suggest will require larger changes, and will depend on the JS implementation. The problem with this solution is that there might be many other similar problems.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.