[Webkit-unassigned] [Bug 50405] New: Update ResourceLoaderSet Enumeration

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50405

           Summary: Update ResourceLoaderSet Enumeration
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: joepeck at webkit.org


From: https://bugs.webkit.org/show_bug.cgi?id=49838#c4
Darin Adler said:

> > WebCore/loader/DocumentLoader.cpp:79
> > +    const ResourceLoaderSet copy = loaders;
> 
> We normally don’t use const for local variables like this one.
> 
> Rather than copying the set it would be more efficient to instead
> use a local vector and the copyToVector function.

Here I'm updating the static functions that take the older approach.

I believe it is more efficient because copying a HashSet requires copying
the inner HashTable, which deals with internal HashTable machinery. In
both cases they use an enumerator, but with copyToVector there isn't
that overhead of the HashTable internals.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.