[Webkit-unassigned] [Bug 50382] [GStreamer] hasVideo/Audio return false until the pipeline reaches PAUSED
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 2 09:54:36 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=50382
Martin Robinson <mrobinson at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #75381|review? |review+
Flag| |
--- Comment #4 from Martin Robinson <mrobinson at webkit.org> 2010-12-02 09:54:36 PST ---
(From update of attachment 75381)
View in context: https://bugs.webkit.org/attachment.cgi?id=75381&action=review
Seems reasonable, but please remove the unecessary lines from the destructor.
> WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:396
> + m_videoTagsTimerHandler = 0;
You shouldn't need to zero this field out in the destructor.
> WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:400
> + m_audioTagsTimerHandler = 0;
Same here.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list