[Webkit-unassigned] [Bug 50228] Theme not updated when MediaPlayer m_private engine changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 2 09:52:18 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=50228


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75385|review?                     |review+
               Flag|                            |




--- Comment #7 from Eric Carlson <eric.carlson at apple.com>  2010-12-02 09:52:18 PST ---
(From update of attachment 75385)
View in context: https://bugs.webkit.org/attachment.cgi?id=75385&action=review

> WebCore/html/HTMLMediaElement.cpp:1964
> +void HTMLMediaElement::mediaPlayerBackendUpdated(MediaPlayer*)

I am not sure about this function name, the term "backend" isn't used anywhere else in this file. "Media engine" is used in both comments and "mediaEngineError", so maybe "mediaPlayerEngineUpdated" or "mediaPlayerEngineChanged" instead?

> WebCore/html/HTMLMediaElement.cpp:1969
> +        toRenderMedia(renderer())->updateFromElement();

Why is this cast necessary, updateFromElement() is called elsewhere in the file without it?


r+, though I would prefer a different name for the callback.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list