[Webkit-unassigned] [Bug 50382] [GStreamer] hasVideo/Audio return false until the pipeline reaches PAUSED

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 2 07:54:50 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=50382


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75377|review?                     |review-
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2010-12-02 07:54:51 PST ---
(From update of attachment 75377)
View in context: https://bugs.webkit.org/attachment.cgi?id=75377&action=review

Seems quite reasonable. I think it needs just a couple fixes.

> WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:208
> +void mediaPlayerPrivateVideoTagsChangedCallback(GObject* element, gint streamId, gpointer data)

You can just make this void mediaPlayerPrivateVideoTagsChangedCallback(GObject* element, gint streamId, MediaPlayerPrivateGStreamer* player)

> WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:214
> +void mediaPlayerPrivateAudioTagsChangedCallback(GObject* element, gint streamId, gpointer data)

Same here.

> WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:346
> +    , m_hasAudio(false)

Shouldn't m_videoTagsTimerHandler and m_audioTagstimreHandler be initialized to 0 here. To guard touching junk data in the destructor?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list